hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-923) libhdfs hdfs_read example uses hdfsRead wrongly
Date Sat, 19 Feb 2011 18:59:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996837#comment-12996837
] 

Hadoop QA commented on HDFS-923:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12440608/hdfs-923.patch
  against trunk revision 1072023.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/201//console

This message is automatically generated.

> libhdfs hdfs_read example uses hdfsRead wrongly
> -----------------------------------------------
>
>                 Key: HDFS-923
>                 URL: https://issues.apache.org/jira/browse/HDFS-923
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: contrib/libhdfs
>            Reporter: Ruyue Ma
>            Assignee: Ruyue Ma
>         Attachments: hdfs-923.patch
>
>
> In the examples of libhdfs,  the hdfs_read.c uses hdfsRead wrongly. 
> {noformat}
>     // read from the file
>     tSize curSize = bufferSize;
>     for (; curSize == bufferSize;) {
>         curSize = hdfsRead(fs, readFile, (void*)buffer, curSize);
>     }
> {noformat} 
> the condition curSize == bufferSize has problem.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message