hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1557) Separate Storage from FSImage
Date Tue, 01 Feb 2011 01:48:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988999#comment-12988999
] 

Suresh Srinivas commented on HDFS-1557:
---------------------------------------

Most of the comments are minor:
# AbstractFileSystem.java - remove unused import IdentityHashMap
# AbstractFileSystem#getStatistics() - can you make only the inner part that accesses HashMap
synchronized, excluding validation of URI.
# minor: remove empty line changes before AbstractFileSystem#getStatistics() method.
# STATISTICS_TABLE declaration goes beyond 80 columns
# FileContext#rename() can you change the link in javadoc from Rename#OVERWRITE to Options.Rename#OVERWRITE
to fix a javadoc warning
# FileContext.java - the newly added methods need not be synchronized as it synchronization
is handled by AbstractFileSystem.
# FileContext#getAllStatistics() in javadoc unnecessarily indicates URISyntaxException is
thrown.
# FileContext#clearStatistics() - javadoc should indicate this method clears statistics for
all the file systems.
# FileContext#getStatistics() - for @param uri, have a fullstop after "the uri to lookup the
statistics".
# FileContext#printStatistics() - why does this method throw IOException? Remove it both from
javadoc and declaration.
# Complete the @param argument for new copy constructor in Statistics.
# FCStatisticsBaseTest - "Base class to test File Context Statistics." instead of File Context
add link to FileContext.
# FCStatisticsBaseTest - why do you need exact URI from getSchemeAuthorityUri()? The API handles
any URI by picking scheme and authority right?
# TestLocalFsFCStatistics - please add comment on why you are doing blockSize + 12? Also please
change the class javadoc to indicate that this is testing stats for LocalFs.


> Separate Storage from FSImage
> -----------------------------
>
>                 Key: HDFS-1557
>                 URL: https://issues.apache.org/jira/browse/HDFS-1557
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 0.23.0
>
>         Attachments: HDFS-1557-branch-0.22.diff, HDFS-1557-branch-0.22.diff, HDFS-1557-trunk.diff,
HDFS-1557-trunk.diff, HDFS-1557-trunk.diff, HDFS-1557.diff, HDFS-1557.diff, HDFS-1557.diff,
HDFS-1557.diff, HDFS-1557.diff, HDFS-1557.diff, HDFS-1557.diff, HDFS-1557.diff
>
>
> FSImage currently derives from Storage and FSEditLog has to call methods directly on
FSImage to access the filesystem. This JIRA is to separate the Storage class out into NNStorage
so that FSEditLog is less dependent on FSImage. From this point, the other parts of the circular
dependency should be easy to fix.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message