hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Reed (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1580) Add interface for generic Write Ahead Logging mechanisms
Date Tue, 01 Feb 2011 19:10:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989338#comment-12989338
] 

Benjamin Reed commented on HDFS-1580:
-------------------------------------

looks good ivan. i like section 1.

i see a couple of small problems in section 2:

1) you have a constructor in the interface. you should either make that a comment (meaning
that is how you will construct those objects using reflection), or you should call it init(...)

2) why is transfer() in WriteAheadLogStreamFactory? shouldn't the transfer happen outside
of the logging? other logic should be reading from the local WAL and transferring to the secondary.

3) can you comment a bit more on upgrade(), rollback(), and finalize()?

> Add interface for generic Write Ahead Logging mechanisms
> --------------------------------------------------------
>
>                 Key: HDFS-1580
>                 URL: https://issues.apache.org/jira/browse/HDFS-1580
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ivan Kelly
>         Attachments: generic_wal_iface.pdf, generic_wal_iface.txt
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message