hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1634) HDFS Federation: Convert single threaded DataNode into per BlockPool thread model.
Date Wed, 23 Feb 2011 21:52:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998565#comment-12998565
] 

Allen Wittenauer commented on HDFS-1634:
----------------------------------------

Why was this committed like this:

-    this.nameNodeAddr = NameNode.getServiceAddress(conf, true);
-    this.nameNodeAddrForClient = NameNode.getAddress(conf);
-    
+
+    // TODO:FEDERATION this.nameNodeAddr = NameNode.getServiceAddress(conf, true);
+    // FEDDERATION this.nameNodeAddrForClient = NameNode.getAddress(conf);
+

This seems like horrendous style. Is the code needed or not?  If it isn't, then why keep it
in a commented bracket?



> HDFS Federation: Convert single threaded DataNode into per BlockPool thread model.
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-1634
>                 URL: https://issues.apache.org/jira/browse/HDFS-1634
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>         Attachments: HDFS-1634-1.patch, HDFS-1634-2.patch
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message