hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allen Wittenauer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1634) HDFS Federation: Convert single threaded DataNode into per BlockPool thread model.
Date Wed, 23 Feb 2011 21:54:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998569#comment-12998569
] 

Allen Wittenauer commented on HDFS-1634:
----------------------------------------

In fact, there is a ton of TODO:FEDERATION comments all over.  

.. and then there is this beauty:

{code}
+    for (BPOfferService bpos : dn.nameNodeThreads) {
+      LOG.info("reg: bpid=" + "; name=" + bpos.bpRegistration.name
+          + "; sid=" + bpos.bpRegistration.storageID + "; nna=" + bpos.nn_addr);
+    }
{code}

LOG.info?  Seriously? What is someone who isn't knee deep in the code supposed to get out
of that log message?

-1

Fix this mess.

> HDFS Federation: Convert single threaded DataNode into per BlockPool thread model.
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-1634
>                 URL: https://issues.apache.org/jira/browse/HDFS-1634
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>         Attachments: HDFS-1634-1.patch, HDFS-1634-2.patch
>
>


-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message