Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Message-ID: <31294136.306781294813425834.JavaMail.jira@thor>
Date: Wed, 12 Jan 2011 01:23:45 -0500 (EST)
From: "Konstantin Boudnik (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Subject: [jira] Commented: (HDFS-1244) Misc improvements to TestFileAppend2
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980580#action_12980580 ] 

Konstantin Boudnik commented on HDFS-1244:
------------------------------------------

coupla nits:
  - as use of log4j has been added would it make sense to replace all System.*.println calls with proper Log's methods invocations?
  - perhaps instead of adding main() method to a test (kinda unorthodox) you might consider using {{@RunWith(Parameterized.class)}}? 

> Misc improvements to TestFileAppend2
> ------------------------------------
>
>                 Key: HDFS-1244
>                 URL: https://issues.apache.org/jira/browse/HDFS-1244
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20-append, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.20-append, 0.22.0
>
>         Attachments: hdfs-1244-0.20-append.txt, hdfs-1244.txt
>
>
> I've made a bunch of improvements to TestFileAppend2:
>  - Now has a main() with various command line options to change the workload (number of DNs, number of threads, etc)
>  - Sleeps for less time in between operations to catch races around close/reopen
>  - Updates to Junit 4 style, adds timeouts
>  - Improves error mesages on failure

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.