hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1496) TestStorageRestore is failing after HDFS-903 fix
Date Sat, 29 Jan 2011 03:12:43 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988372#action_12988372
] 

Konstantin Boudnik commented on HDFS-1496:
------------------------------------------

Hairong, what I am seen on a real (0.20.2 based cluster) the NN storage volume which has been
once removed (e.g. because of a faulty NFS mount or something) is emptied as soon SNN starts
checkpoint process. This happens because {{FSEditLog.synchronized void rollEditLog}} calls
{{FSImage.attemptRestoreRemovedStorage}} and effectively formats a faulty volume if it becomes
available.

I guess it is possible that a checkpoint can happen before rollEditLog was called and than
the inconsistency you've mentioned might be introduced. I think it won't happen because {{SecondaryNameNode.doMerge}}
iterates through Storage.storageDirs which won't contain failed volume unless it has been
restored and formatted. If this all is true then we have a test which is failing not because
the feature doesn't work but rather because the test needs to be changed in lights of HDFS-903.

Please let me know if my analysis is incorrect.

> TestStorageRestore is failing after HDFS-903 fix
> ------------------------------------------------
>
>                 Key: HDFS-1496
>                 URL: https://issues.apache.org/jira/browse/HDFS-1496
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.22.0, 0.23.0
>            Reporter: Konstantin Boudnik
>            Assignee: Hairong Kuang
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1496.sh, HDFS-1496.sh, HDFS-1496.sh
>
>
> TestStorageRestore seems to be failing after HDFS-903 commit. Running git bisect confirms
it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message