hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1572) Checkpointer should trigger checkpoint with specified period.
Date Wed, 19 Jan 2011 02:08:44 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983495#action_12983495
] 

Konstantin Shvachko commented on HDFS-1572:
-------------------------------------------

+1 Looks good to me.

> Checkpointer should trigger checkpoint with specified period.
> -------------------------------------------------------------
>
>                 Key: HDFS-1572
>                 URL: https://issues.apache.org/jira/browse/HDFS-1572
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Liyin Liang
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: 1527-1.diff, 1572-2.diff, HDFS-1572-2.patch, HDFS-1572-3.patch,
HDFS-1572.patch
>
>
> {code:}
>   long now = now();
>   boolean shouldCheckpoint = false;
>   if(now >= lastCheckpointTime + periodMSec) {
>     shouldCheckpoint = true;
>   } else {
>     long size = getJournalSize();
>     if(size >= checkpointSize)
>       shouldCheckpoint = true;
>   }
> {code}
> {dfs.namenode.checkpoint.period} in configuration determines the period of checkpoint.
However, with above code, the Checkpointer triggers a checkpoint every 5 minutes (periodMSec=5*60*1000).
According to SecondaryNameNode.java, the first *if*  statement should be:
>  {code:}
> if(now >= lastCheckpointTime + 1000 * checkpointPeriod) {
>  {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message