hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1502) TestBlockRecovery triggers NPE in assert
Date Thu, 02 Dec 2010 07:57:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966009#action_12966009
] 

Konstantin Shvachko commented on HDFS-1502:
-------------------------------------------

Your fix caused the problem with testRBWReplicas & testRWRReplicas.
You mocked {{InterDatanodeProtocol.updateReplicaUnderRecovery(oldBlock, recoveryId, newLen)}}
to return the {{oldBlock}}.
But {{updateReplicaUnderRecovery()}} is supposed to update the old replica with the {{newGS=recoveryId}}
and {{newLen}}.
Good thing DataNode assert caught you.

> TestBlockRecovery triggers NPE in assert
> ----------------------------------------
>
>                 Key: HDFS-1502
>                 URL: https://issues.apache.org/jira/browse/HDFS-1502
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Eli Collins
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1502.patch
>
>
> {noformat}
> Testcase: testRBW_RWRReplicas took 10.333 sec
>         Caused an ERROR
> null
> java.lang.NullPointerException
>         at org.apache.hadoop.hdfs.server.datanode.DataNode.syncBlock(DataNode.java:1881)
>         at org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.testSyncReplicas(TestBlockRecovery.java:144)
>         at org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery.testRBW_RWRReplicas(TestBlockRecovery.java:305)
> {noformat}
> {noformat}
>         Block reply = r.datanode.updateReplicaUnderRecovery(
>             r.rInfo, recoveryId, newBlock.getNumBytes());
>         assert reply.equals(newBlock) &&
>                reply.getNumBytes() == newBlock.getNumBytes() :
>           "Updated replica must be the same as the new block.";    <----- line 1881
> {noformat}
> Not sure how reply could be null since  updateReplicaUnderRecovery always returns a newly
instantiated object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message