hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1506) Refactor fsimage loading code
Date Fri, 03 Dec 2010 01:14:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966374#action_12966374
] 

Todd Lipcon commented on HDFS-1506:
-----------------------------------

Looks pretty good. Just some small nits and then +1 from my viewpoint.

- FSNamesystem member in FSImageFormat.Loader should probably be marked final and maybe declared
up with {{conf}} rather than down with the "output" members
- The indentation is off on the loadFullNameINodes function
- The indentation of the addToParent() function arguments is pretty strange looking
- A few whitespace lines removed needlessly (before spaceConsumedInTree and following two
functions)


> Refactor fsimage loading code
> -----------------------------
>
>                 Key: HDFS-1506
>                 URL: https://issues.apache.org/jira/browse/HDFS-1506
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.23.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>         Attachments: refactorImageLoader.patch
>
>
> I plan to do some code refactoring to make HDFS-1070 simpler. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message