hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hairong Kuang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1524) Image loader should make sure to read every byte in image file
Date Wed, 01 Dec 2010 22:08:15 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965873#action_12965873

Hairong Kuang commented on HDFS-1524:

     [exec] -1 overall.  
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]     -1 tests included.  The patch doesn't appe
     [exec] ar to include any new or modified tests.
     [exec]                         Please justify why no new tests are needed for this patch.
     [exec]                         Also please list what manual steps were performed to verify
this patch.
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9)
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec]     +1 system test framework.  The patch passed system test framework compile.

Failed unit tests are all known ones:
TestHDFSTrash (timeout)

Since the change is trivial and it is hard to come up with the test case, I will not provide
a unit test and commit the patch.

> Image loader should make sure to read every byte in image file
> --------------------------------------------------------------
>                 Key: HDFS-1524
>                 URL: https://issues.apache.org/jira/browse/HDFS-1524
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.22.0, 0.23.0
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>            Priority: Blocker
>             Fix For: 0.22.0, 0.23.0
>         Attachments: eofImageFile.patch
> When I work on HDFS-1070, I come across a very strange bug. Occasionally when loading
a compressed image, NameNode throws an exception complaining that the image file is corrupt.
However, the result returned by the md5sum utility matches the checksum value stored in the
VERSION file. 
> It turns out the image loader leaves 4 bytes unread after loading all the real data of
an image. Those unread bytes may be some compression-related meta-info. The image loader should
make sure to read to the end of file in order for an correct checksum.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message