hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hairong Kuang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1497) Write pipeline sequence numbers should be sequential with no skips or duplicates
Date Tue, 07 Dec 2010 15:13:10 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968776#action_12968776
] 

Hairong Kuang commented on HDFS-1497:
-------------------------------------

Todd, thanks for addressing my concern. The patch looks good but I hope that you can clean
it a little bit. Something like this in the beginning of hflush should be good enough. I feel
that you are in the mode of "assertion". :)
{code}
if (bytesCurBlock + buffered data size == lastFlushedOffset) {
  // no new data
  return;
}
{code}

> Write pipeline sequence numbers should be sequential with no skips or duplicates
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-1497
>                 URL: https://issues.apache.org/jira/browse/HDFS-1497
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.20-append, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-1497.txt, hdfs-1497.txt, hdfs-1497.txt
>
>
> In HDFS-895 we discovered that multiple hflush() calls in a row without intervening writes
could cause a skip in sequence number. This doesn't seem to have any direct consequences,
but we should maintain and assert the invariant that sequence numbers have no gaps or duplicates.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message