Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 25319 invoked from network); 18 Nov 2010 01:27:07 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 18 Nov 2010 01:27:07 -0000 Received: (qmail 65944 invoked by uid 500); 18 Nov 2010 01:27:38 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 65907 invoked by uid 500); 18 Nov 2010 01:27:38 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 65899 invoked by uid 99); 18 Nov 2010 01:27:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Nov 2010 01:27:38 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Nov 2010 01:27:36 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oAI1REXk013191 for ; Thu, 18 Nov 2010 01:27:15 GMT Message-ID: <7558439.166951290043634798.JavaMail.jira@thor> Date: Wed, 17 Nov 2010 20:27:14 -0500 (EST) From: "Todd Lipcon (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Updated: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated HDFS-1473: ------------------------------ Attachment: hdfs-1473-prelim.txt Here's a super-preliminary patch for this. I moved around the bulk of the stuff that had to move, but there are still some things that need some real cleanup plus new javadoc. For example, there are currently 6 constructors used for FSImage which get pretty messy, since we now have a {{conf}} member. Just wanted to upload the patch to get comments if the general division of classes seems reasonable > Refactor storage management into separate classes than fsimage file reading/writing > ----------------------------------------------------------------------------------- > > Key: HDFS-1473 > URL: https://issues.apache.org/jira/browse/HDFS-1473 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Attachments: hdfs-1473-prelim.txt > > > Currently the FSImage class is responsible both for storage management (eg moving around files, tracking file names, the VERSION file, etc) as well as for the actual serialization and deserialization of the "fsimage" file within the storage directory. > I'd like to refactor the loading and saving code into new classes. This will make testing easier and also make the major changes in HDFS-1073 easier to understand. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.