Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Message-ID: <33288144.266811290537794522.JavaMail.jira@thor>
Date: Tue, 23 Nov 2010 13:43:14 -0500 (EST)
From: "Todd Lipcon (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Subject: [jira] Commented: (HDFS-1503) TestSaveNamespace fails
In-Reply-To: <22969767.156921290023295582.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934965#action_12934965 ] 

Todd Lipcon commented on HDFS-1503:
-----------------------------------

Sure, no problem. This test uses a mockito "spy" object to inject some code right before the saveFSImage call. In some cases we want to call through to the original saveFSImage, in other cases we just want to throw an exception. For whatever reason, an incorrect change was made in HDFS-1071 which made the "call through" case call through to the same spy object rather than the unmodified class, so of course it infinitely recursed and blew out the stack. The patch switches to using the more "proper" way of doing this in Mockito - the callRealMethod() function.

> TestSaveNamespace fails
> -----------------------
>
>                 Key: HDFS-1503
>                 URL: https://issues.apache.org/jira/browse/HDFS-1503
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Eli Collins
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hdfs-1503.txt, TEST-org.apache.hadoop.hdfs.server.namenode.TestSaveNamespace.txt
>
>
> Will attach the full log. Here's the relevant snippet:
> {noformat}
> Exception in thread "FSImageSaver for /home/eli/src/hdfs4/build/test/data/dfs/na
> me1 of type IMAGE_AND_EDITS" java.lang.RuntimeException: Injected fault: saveFSI
> mage second time
> ....
>         at java.lang.Thread.run(Thread.java:619)
> Exception in thread "FSImageSaver for /home/eli/src/hdfs4/build/test/data/dfs/na
> me2 of type IMAGE_AND_EDITS" java.lang.StackOverflowError
>         at java.util.Arrays.copyOf(Arrays.java:2882)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.