Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 65630 invoked from network); 17 Nov 2010 23:35:04 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 17 Nov 2010 23:35:04 -0000 Received: (qmail 60057 invoked by uid 500); 17 Nov 2010 23:35:35 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 60023 invoked by uid 500); 17 Nov 2010 23:35:35 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 60015 invoked by uid 99); 17 Nov 2010 23:35:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Nov 2010 23:35:35 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Nov 2010 23:35:35 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oAHNZF04010007 for ; Wed, 17 Nov 2010 23:35:15 GMT Message-ID: <18424148.164811290036915106.JavaMail.jira@thor> Date: Wed, 17 Nov 2010 18:35:15 -0500 (EST) From: "Eli Collins (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-1507) TestAbandonBlock should abandon a block In-Reply-To: <19117183.164511290036074711.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933236#action_12933236 ] Eli Collins commented on HDFS-1507: ----------------------------------- Release audit warnings are unrelated. Just modified TestAbandonBlock so I just ran it. {noformat} [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] -1 release audit. The applied patch generated 103 release audit warnings (more than the trunk's current 1 warnings). [exec] [exec] +1 system test framework. The patch passed system test framework compile. [exec] {noformat} > TestAbandonBlock should abandon a block > --------------------------------------- > > Key: HDFS-1507 > URL: https://issues.apache.org/jira/browse/HDFS-1507 > Project: Hadoop HDFS > Issue Type: Bug > Components: test > Affects Versions: 0.22.0, 0.23.0 > Reporter: Eli Collins > Assignee: Eli Collins > Priority: Minor > Fix For: 0.22.0, 0.23.0 > > Attachments: hdfs-1507-1.patch > > > TestAbandonBlock as written just tests that if one client tries to abandon another it will fail because the new client doesn't have a lease on the other client's file, which doesn't cover the block abandonement code path. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.