hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1513) Fix a number of warnings
Date Tue, 23 Nov 2010 01:52:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934698#action_12934698
] 

Eli Collins commented on HDFS-1513:
-----------------------------------

Thanks Cos. 

{noformat}
     [exec] 
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 15 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 103 release audit warnings
(more than the trunk's current 98 warnings).
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test framework compile.
     [exec] 
{noformat}

The rat report failure is due to the following being in the report that's run with my patch
vs the default one (as files that don't contain a license). I'm not sure why the default run
doesn't include these, this patch doesn't modify them.  

{noformat}
[rat:report]  !????? /home/eli/src/hdfs-trunk/build/hadoop-hdfs-PATCH-hdfs-1513-1.patch/conf/core-site.xml
[rat:report]  !????? /home/eli/src/hdfs-trunk/build/hadoop-hdfs-PATCH-hdfs-1513-1.patch/conf/hadoop-env.sh
[rat:report]  !????? /home/eli/src/hdfs-trunk/build/hadoop-hdfs-PATCH-hdfs-1513-1.patch/conf/hadoop-policy.xml
[rat:report]  !????? /home/eli/src/hdfs-trunk/build/hadoop-hdfs-PATCH-hdfs-1513-1.patch/conf/masters
[rat:report]  !????? /home/eli/src/hdfs-trunk/build/hadoop-hdfs-PATCH-hdfs-1513-1.patch/conf/slaves
{noformat}


> Fix a number of warnings
> ------------------------
>
>                 Key: HDFS-1513
>                 URL: https://issues.apache.org/jira/browse/HDFS-1513
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.22.0, 0.23.0
>
>         Attachments: hdfs-1513-1.patch
>
>
> There are a bunch of warnings besides DeprecatedUTF8, HDFS-1512 and two warnings caused
by a Java bug (http://bugs.sun.com/view_bug.do?bug_id=646014) that we can fix.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message