hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1498) FSDirectory#unprotectedConcat calls setModificationTime on a file
Date Sun, 14 Nov 2010 21:51:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931898#action_12931898

Konstantin Boudnik commented on HDFS-1498:

BTW, it has been discussed a few times - there's no need to add numerical modifier to a patch
file: JIRA takes care about this automatically.

> FSDirectory#unprotectedConcat calls setModificationTime on a file
> -----------------------------------------------------------------
>                 Key: HDFS-1498
>                 URL: https://issues.apache.org/jira/browse/HDFS-1498
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.22.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.22.0
>         Attachments: hdfs-1498-1.patch
> The HDFSConcat test fails when asserts are enabled because FSDirectory#unprotectedConcat
calls INode#setModificationTime on a file, this method asserts that the argument is a directory.
It should use setModificationTimeForce since we know the target is a file, it's mod time should
be set to now unconditionally since we know we're modifying it. The behavior should be equivalent.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message