hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1486) Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for web testing)
Date Mon, 15 Nov 2010 04:45:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931976#action_12931976
] 

Eli Collins commented on HDFS-1486:
-----------------------------------

Hey Cos,

In CmdFactoryDFS seems like getCommandExecutor should be a method of CLICommand, this way
you don't need to check cmd instanceof CLITestData.CLITestCmd, and saves you from having CLITestCmd
specific implementation code in the abstract CmdFactoryDFS class?   Otherwise looks great.

Thanks,
Eli


> Generalize CLITest structure and interfaces to faciliate upstream adoption (e.g. for
web testing)
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1486
>                 URL: https://issues.apache.org/jira/browse/HDFS-1486
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-1486.patch, HDFS-1486.patch, HDFS-1486.patch
>
>
> HDFS part of HADOOP-7014. HDFS side of TestCLI doesn't require any special changes but
needs to be aligned with Common

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message