hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-259) Remove intentionally corrupt 0.13 directory layout creation
Date Wed, 17 Nov 2010 20:37:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933145#action_12933145
] 

Eli Collins commented on HDFS-259:
----------------------------------

+1    Latest patch looks good.  I ran test-core and verified the test failures were the ones
currently failing on trunk.

{noformat}
     [exec] 
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 97 release audit warnings (more
than the trunk's current 1 warnings).
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test framework compile.
     [exec] 
{noformat}


> Remove intentionally corrupt 0.13 directory layout creation
> -----------------------------------------------------------
>
>                 Key: HDFS-259
>                 URL: https://issues.apache.org/jira/browse/HDFS-259
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.0
>
>         Attachments: hdfs-259.txt, hdfs-259.txt, hdfs-259.txt, hdfs-259.txt, hdfs-259.txt,
hdfs-259.txt
>
>
> Given that 0.13 is incredibly old at this point, I think the likelihood of anyone trying
to start an 0.20+ namenode on an 0.13 directly layout is essentially nil. The intentionally-corrupt
"${dfs.name.dir}/image/" directory just serves to confuse new users at this point, so I propose
removing it.
> If no one objects, I'll submit a patch. If there are objections, I propose at least adding
a README explaining its purpose (same text as in the corrupt fsimage file)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message