hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Kling (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1483) DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding blocks are corrupt
Date Wed, 17 Nov 2010 04:08:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12932805#action_12932805
] 

Patrick Kling commented on HDFS-1483:
-------------------------------------

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     -1 findbugs.  The patch appears to introduce 3 new Findbugs warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 97 release audit warnings (more
than the trunk's current 1 warnings).
     [exec] 
     [exec]     +1 system test framework.  The patch passed system test framework compile.

The findbugs/release audit warnings are not caused by this patch (see MAPREDUCE-2172).


> DFSClient.getBlockLocations returns BlockLocations with no indication that the corresponding
blocks are corrupt
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1483
>                 URL: https://issues.apache.org/jira/browse/HDFS-1483
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>            Reporter: Patrick Kling
>            Assignee: Patrick Kling
>         Attachments: HDFS-1483.2.patch, HDFS-1483.patch
>
>
> When there are no uncorrupted replicas of a block, FSNamesystem.getBlockLocations returns
LocatedBlocks corresponding to corrupt blocks. When DFSClient converts these to BlockLocations,
the information that the corresponding block is corrupt is lost. We should add a field to
BlockLocation to indicate whether the corresponding block is corrupt in order to warn the
client that reading this block will fail. This would be especially useful for tools such as
RAID FSCK, which could then easily inspect whether data or parity blocks are corrupted without
having to make direct RPC calls.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message