hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1434) Refactor Datanode#startDataNode method
Date Tue, 05 Oct 2010 01:00:33 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917846#action_12917846
] 

Konstantin Boudnik commented on HDFS-1434:
------------------------------------------

The patch doesn't include any tests. Why? Is it ok? 

> Refactor Datanode#startDataNode method
> --------------------------------------
>
>                 Key: HDFS-1434
>                 URL: https://issues.apache.org/jira/browse/HDFS-1434
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1434.patch
>
>
> This method is very long, approximately 190 lines. Splitting this method into smaller
methods. This also helps in federation where some of the initialization in this methods will
be done once for a datanode and others once in every heartbeat thread per namenode in DN.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message