hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1434) Refactor Datanode#startDataNode method
Date Tue, 05 Oct 2010 01:09:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917849#action_12917849
] 

Suresh Srinivas commented on HDFS-1434:
---------------------------------------

Sorry cut and paste error in my previous comment. It excluded this:
The patch does not include tests because this is refactoring the existing method into smaller
methods. The existing tests cover the changes in the patch.

> Refactor Datanode#startDataNode method
> --------------------------------------
>
>                 Key: HDFS-1434
>                 URL: https://issues.apache.org/jira/browse/HDFS-1434
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1434.patch
>
>
> This method is very long, approximately 190 lines. Splitting this method into smaller
methods. This also helps in federation where some of the initialization in this methods will
be done once for a datanode and others once in every heartbeat thread per namenode in DN.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message