hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HDFS-1462) Refactor edit log loading to a separate class from edit log writing
Date Wed, 20 Oct 2010 20:02:26 GMT

     [ https://issues.apache.org/jira/browse/HDFS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Todd Lipcon updated HDFS-1462:
------------------------------

    Attachment: hdfs-1462.txt

Ran test-patch, got:

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 9 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     -1 findbugs.  The patch appears to introduce 1 new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec] 
     [exec]     +1 system tests framework.  The patch passed system tests framework compile.

The new findbugs warning is:
bq. Should org.apache.hadoop.hdfs.server.namenode.FSEditLog$Ops be a _static_ inner class?

which seems reasonable enough. New patch fixes this - test-patch is all +1 on this version.
Should be good to go pending review.

> Refactor edit log loading to a separate class from edit log writing
> -------------------------------------------------------------------
>
>                 Key: HDFS-1462
>                 URL: https://issues.apache.org/jira/browse/HDFS-1462
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-1462.txt, hdfs-1462.txt, hdfs-1462.txt
>
>
> Before the major work in HDFS-1073, I'd like to do this refactor to clean up the monster
FSEditLog class. We can separate all the functions that take of loading edits into an FSN
from the functions that take care of writing edits, rolling, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message