hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1444) Test related code of build.xml is error-prone and needs to be re-aligned.
Date Fri, 08 Oct 2010 22:40:32 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919399#action_12919399
] 

Konstantin Boudnik commented on HDFS-1444:
------------------------------------------

I have ran {{test-patch.sh}} locally:
{noformat}
+1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 system tests framework.  The patch passed system tests framework compile.
{noformat}

> Test related code of build.xml is error-prone and needs to be re-aligned.
> -------------------------------------------------------------------------
>
>                 Key: HDFS-1444
>                 URL: https://issues.apache.org/jira/browse/HDFS-1444
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.21.1
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>            Priority: Minor
>         Attachments: HDFS-1444.patch
>
>
> Test related parts of build.xml introduce at least two places (effectively different)
for test classes destination compilation.
> Then some extra logic is applied at say test-jar creation step where the content of one
is copied over to another. Etc.
> This seems to be overcomplicated and is better be fixed to prevent possible issues with
future build modificaitons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message