hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Boris Shkolnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1456) Provide builder for constructing instances of MiniDFSCluster
Date Mon, 18 Oct 2010 20:34:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922240#action_12922240
] 

Boris Shkolnik commented on HDFS-1456:
--------------------------------------

except for some leftover comments , like this (// cluster = new MiniDFSCluster.Builder(conf).numDataNodes(0).format(false))
it looks good.

I looked thru the patch at most of the substitutions , but since it so huge, I heavily rely
on the fact that all the tests have passed.

+1

> Provide builder for constructing instances of MiniDFSCluster
> ------------------------------------------------------------
>
>                 Key: HDFS-1456
>                 URL: https://issues.apache.org/jira/browse/HDFS-1456
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1456-2.patch, HDFS-1456.patch
>
>
> Time to fix a broken window. Of the 293 occurences of "new MiniDFSCluster("... most look
something like:
> {noformat}cluster = new MiniDFSCluster(0, config, numDatanodes, true, false, true,  null,
null, null, null);{noformat}
> The largest constructor takes 10 parameters, and even the overloaded constructors can
be difficult to read as their mainaly nulls or booleans.
> We should provide a Builder for constructing MiniDFSClusters to improve readability.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message