Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Message-ID: <874349.262121284763236258.JavaMail.jira@thor>
Date: Fri, 17 Sep 2010 18:40:36 -0400 (EDT)
From: "Boris Shkolnik (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Subject: [jira] Commented: (HDFS-1365) HDFS federation: propose ClusterID
 and BlockPoolID format
In-Reply-To: <26111677.121031283368014610.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910830#action_12910830 ] 

Boris Shkolnik commented on HDFS-1365:
--------------------------------------

1.LOG in TestStorageInfo is not used

2. Lots of code (like TestStorageInfo, UpgradeUtilities and others are  twice in the patch


3. newBlockPoolID  - if we cannot get new IP , should we use "unknownIP" or throw an exception?

4. we should not have spaces in cluster id. (cid - otherstuff)

5. can we do without if (sv == null || st == null || sid == null || scid == null || sbpid == null +  || sct == null) {
in Storage.java:getFields()?  Also please remove commented out lines there..

> HDFS federation: propose ClusterID and BlockPoolID format
> ---------------------------------------------------------
>
>                 Key: HDFS-1365
>                 URL: https://issues.apache.org/jira/browse/HDFS-1365
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Tanping Wang
>            Assignee: Tanping Wang
>             Fix For: Federation Branch
>
>         Attachments: HDFS1365-branch-HDFS1052.1.patch, HDFS1365-branch1052.2.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.