Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Message-ID: <4850078.488851285888773333.JavaMail.jira@thor>
Date: Thu, 30 Sep 2010 19:19:33 -0400 (EDT)
From: "Dmytro Molkov (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Subject: [jira] Commented: (HDFS-1155) getDatanodeReport can be moved to
 NameNodeProtocol from ClientProtocol
In-Reply-To: <29022713.46291273858604707.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916730#action_12916730 ] 

Dmytro Molkov commented on HDFS-1155:
-------------------------------------

My original assumption is not entirely accurate. Instead of moving the method I would like to duplicate the definition in the NameNode protocol and only make changes to the Balancer code to use a single nameNode protocol to talk to the namenode.

> getDatanodeReport can be moved to NameNodeProtocol from ClientProtocol
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1155
>                 URL: https://issues.apache.org/jira/browse/HDFS-1155
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Dmytro Molkov
>            Assignee: Dmytro Molkov
>
> Right now getDatanodeReport is being used in only two places in the HDFS code: the Balancer and DFSAdmin. And it is the only reason for these classes to use DFSClient. If we would move the method definition (or copy for now deprecating the old location) to the NameNode protocol DFSAdmin and Balancer will not rely on DFSClient anymore and will be cleaner. This will also help the Balancer to run cleaner against HDFS-599 changes.
> Thoughts?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.