[ https://issues.apache.org/jira/browse/HDFS-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Boris Shkolnik updated HDFS-1394:
---------------------------------

    Attachment: HDFS-1394-8.patch

    *  Before Line 138: Is there anything that needs to be done for simulated storage?
  it is done in HDFS-1365     
    * DataStorage.java's only change is whitespace. This can be removed.
Done.
    * Nit: FsImage:guessClusterId seems like an odd name. determineClusterId?
Done.
    * Reading through guessClusterId I was initially confused as to if it were ok to return a null to indicate failure. Javadoc on the method would help.
Done.
    * Line 279: if(!(System.in.read() == 'Y')) could be simplified to if(System.in.read != 'Y')
Done.
    * In the tests there are quite a few calls to NameNode.clusterIdStr = "TestClusterId"; these should be refactored into a static method on GenericTestUtils.java.
Done.
    * There are currently no tests that go over the -genclusterid paths. This could be tested in TestHDFSCLI
It cannot be tested with TestHDFSCLI, because it assumes 'dfs' command and not 'namenode'
    * This changes user-interaction with the Namenode, so the forrest docs need to be updated as well.
the relevent doc is in hadoop-common. Created HADOOP-6967 for this issue.

> modify -format option for namenode to generated new blockpool id and accept newcluster
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-1394
>                 URL: https://issues.apache.org/jira/browse/HDFS-1394
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: Federation Branch
>            Reporter: Boris Shkolnik
>            Assignee: Boris Shkolnik
>         Attachments: HDFS-1394-5.patch, HDFS-1394-6.patch, HDFS-1394-7.patch, HDFS-1394-7.patch, HDFS-1394-8.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.