hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HDFS-1304) There is no unit test for HftpFileSystem.open(..)
Date Wed, 22 Sep 2010 22:24:33 GMT

     [ https://issues.apache.org/jira/browse/HDFS-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tsz Wo (Nicholas), SZE updated HDFS-1304:
-----------------------------------------

    Attachment: h1304_20100922.patch

Thanks Cos for reviewing it.

h1304_20100922.patch: 

> please have messages for the asserts
The assert messages will be printed only when the test failed.  In such case, we can check
the stack trace.

>  remove commented code
Moved the  commented codes to a method.  

> these imports aren't used anywhere and can be removed as well ...
Removed.



> There is no unit test for HftpFileSystem.open(..)
> -------------------------------------------------
>
>                 Key: HDFS-1304
>                 URL: https://issues.apache.org/jira/browse/HDFS-1304
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h1304_20100921.patch, h1304_20100922.patch
>
>
> HftpFileSystem.open(..) first opens an URL connection to namenode's FileDataServlet and
then is redirected to datanode's StreamFile servlet.  Such redirection does not work in the
unit test environment because the redirect URL uses real hostname instead of localhost.
> One way to get around it is to use fault-injection in order to replace the real hostname
with localhost.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message