hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-881) Refactor DataNode Packet header into DataTransferProtocol
Date Mon, 06 Sep 2010 23:57:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906624#action_12906624
] 

Todd Lipcon commented on HDFS-881:
----------------------------------

test-patch shows:
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
     [exec] 
     [exec]     +1 system tests framework.  The patch passed system tests framework compile.
     [exec] 

The one javadoc warning is:

     [exec]   [javadoc] /data/1/scratch/patchqueue/patch-worker-27503/patch_89/svnrepo/src/java/org/apache/hadoop/hdfs/server/datanode/metrics/FSDatasetMBean.java:40:
warning - Tag @see: reference not found: org.apache.hadoop.hdfs.server.datanode.metrics.DataNodeStatisticsMBean

which is unrelated and already covered in HDFS-1369.

I also ran the full unit test suite, got some failures, but all of them are already reported
in other JIRAs and are unrelated to this patch.

> Refactor DataNode Packet header into DataTransferProtocol
> ---------------------------------------------------------
>
>                 Key: HDFS-881
>                 URL: https://issues.apache.org/jira/browse/HDFS-881
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-881.txt, hdfs-881.txt
>
>
> The Packet Header format is used ad-hoc in various places. This JIRA is to refactor it
into a class inside DataTransferProtocol (like was done with PipelineAck)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message