hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1320) Add LOG.isDebugEnabled() guard for each LOG.debug("...")
Date Thu, 16 Sep 2010 21:09:33 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910319#action_12910319
] 

Hudson commented on HDFS-1320:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #389 (See [https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/389/])
    HDFS-1320. Improve the error messages when using hftp://.


> Add LOG.isDebugEnabled() guard for each LOG.debug("...")
> --------------------------------------------------------
>
>                 Key: HDFS-1320
>                 URL: https://issues.apache.org/jira/browse/HDFS-1320
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>            Assignee: Erik Steffl
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1320-0.22-1.patch, HDFS-1320-0.22-2.patch, HDFS-1320-0.22-3.patch,
HDFS-1320-0.22.patch
>
>
> Each LOG.debug("...") should be executed only if LOG.isDebugEnabled() is true, in some
cases it's expensive to construct the string that is being printed to log. It's much easier
to always use LOG.isDebugEnabled() because it's easier to check (rather than in each case
reason wheather it's neccessary or not).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message