hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-718) configuration parameter to prevent accidental formatting of HDFS filesystem
Date Wed, 15 Sep 2010 04:45:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909587#action_12909587
] 

Hadoop QA commented on HDFS-718:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12454051/HDFS-718-3.patch
  against trunk revision 997157.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system tests framework.  The patch passed system tests framework compile.

Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/238/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/238/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/238/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/238/console

This message is automatically generated.

> configuration parameter to prevent accidental formatting of HDFS filesystem
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-718
>                 URL: https://issues.apache.org/jira/browse/HDFS-718
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.22.0
>         Environment: Any
>            Reporter: Andrew Ryan
>            Assignee: Andrew Ryan
>            Priority: Minor
>         Attachments: HDFS-718-3.patch, HDFS-718.patch-2.txt, HDFS-718.patch.txt
>
>
> Currently, any time the NameNode is not running, an HDFS filesystem will accept the 'format'
command, and will duly format itself. There are those of us who have multi-PB HDFS filesystems
who are really quite uncomfortable with this behavior. There is "Y/N" confirmation in the
format command, but if the formatter genuinely believes themselves to be doing the right thing,
the filesystem will be formatted.
> This patch adds a configuration parameter to the namenode, dfs.namenode.support.allowformat,
which defaults to "true," the current behavior: always allow formatting if the NameNode is
down or some other process is not holding the namenode lock. But if dfs.namenode.support.allowformat
is set to "false," the NameNode will not allow itself to be formatted until this config parameter
is changed to "true".
> The general idea is that for production HDFS filesystems, the user would format the HDFS
once, then set dfs.namenode.support.allowformat to "false" for all time.
> The attached patch was generated against trunk and +1's on my test machine. We have a
0.20 version that we are using in our cluster as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message