Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Message-ID: <3802025.242781281388997822.JavaMail.jira@thor>
Date: Mon, 9 Aug 2010 17:23:17 -0400 (EDT)
From: "Erik Steffl (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Subject: [jira] Commented: (HDFS-1320) Add LOG.isDebugEnabled() guard for
 each LOG.debug("...")
In-Reply-To: <24594537.11251280185637308.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896698#action_12896698 ] 

Erik Steffl commented on HDFS-1320:
-----------------------------------

Patch HDFS-1320-0.22-2.patch fixes problems mentioned in the review:

1. All files you mentioned and few others are now patched (fixed my script that searches for calls to .debug() with no isDebugEnabled()).

2. BlockPlacementPolicyDefault.java: logr replaced by FSNamesystem.LOG

3. DFSUtil is already removed from both NameNode.java and DataNode.java

4. DFSClient is already removed from BlockTokenIdentifier

5. Removed FileStatus import from DFSOutputStream

6. They are already there, think I'll leave them there for consistency

> Add LOG.isDebugEnabled() guard for each LOG.debug("...")
> --------------------------------------------------------
>
>                 Key: HDFS-1320
>                 URL: https://issues.apache.org/jira/browse/HDFS-1320
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Erik Steffl
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1320-0.22-1.patch, HDFS-1320-0.22-2.patch, HDFS-1320-0.22.patch
>
>
> Each LOG.debug("...") should be executed only if LOG.isDebugEnabled() is true, in some cases it's expensive to construct the string that is being printed to log. It's much easier to always use LOG.isDebugEnabled() because it's easier to check (rather than in each case reason wheather it's neccessary or not).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.