hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1343) Instrumented build should be concentrated in one build area
Date Mon, 30 Aug 2010 03:28:53 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904071#action_12904071
] 

Konstantin Boudnik commented on HDFS-1343:
------------------------------------------

As Apache Hudson doesn't function for a few weeks now I have ran {{test-patch.sh}} locally:
{noformat}

-1 overall.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 system tests framework.  The patch passed system tests framework compile.
{noformat}

The warning in question is caused by 
{noformat}
  [javadoc] /homes/cos/work/git/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/metrics/FSDatasetMBean.java:40:
warning - Tag @see: reference not found: org.apache.hadoop.h
dfs.server.datanode.metrics.DataNodeStatisticsMBean
{noformat}
Which clearly isn't related to the scope of the patch.

{{run-commit-test}} shows no surprises: all passed but {{org.apache.hadoop.hdfs.TestFileStatus}}
which I think has been broken for a while now.
I'll be committing this after formal review process is over.


> Instrumented build should be concentrated in one build area
> -----------------------------------------------------------
>
>                 Key: HDFS-1343
>                 URL: https://issues.apache.org/jira/browse/HDFS-1343
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>            Priority: Minor
>         Attachments: hdfs-1343.patch
>
>
> Current instrumented build is inefficient in a sense that part of it is build under build-fi
and another part is under build-fi/system.
> This doubles the time of some classes and tests compilation. And needed to be fixed.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message