hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1152) appendFile does not recheck lease in second synchronized block
Date Mon, 30 Aug 2010 18:46:53 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904280#action_12904280
] 

Konstantin Shvachko commented on HDFS-1152:
-------------------------------------------

Todd, it seems to me that the two synchronized sections should actually be one. There is some
redundant work done in the second section, and also the consistency of actions is not clear
to me, because if you release the lock in the middle then you basically need to verify everything
again, say lease may expire or permissions can change. Looks to me that either we should move
the second section inside startFileInternal() or remove it if this is a redundant code. 
Let's target this jira for 0.20-append. I'll create another one for trunk and will take a
closer look at the problem.

> appendFile does not recheck lease in second synchronized block
> --------------------------------------------------------------
>
>                 Key: HDFS-1152
>                 URL: https://issues.apache.org/jira/browse/HDFS-1152
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.20-append, 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: appendFile-recheck-lease.txt, hdfs-1152.txt
>
>
> FSN.appendFile is made up of two synchronized sections. The second section assumes that
the file has not gotten modified during the unsynchronized part in between. We should recheck
the lease in the second block.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message