hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-806) Add new unit tests to the 10-mins 'run-commit-test' target
Date Thu, 05 Aug 2010 04:30:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895538#action_12895538
] 

Konstantin Boudnik commented on HDFS-806:
-----------------------------------------

bq. Can we make that target a pre-req for commit test, or just call it directly rather than
duplicating the code? 
- Pre-req will create an issue if someone will run {{run-commit-test}} with -Dtestcase. In
this scenario, if a testcase is from unit suite then it will be executed. And it doesn't matter
that {{unless="testcase"}} clause will be in effect.

- calling directly means a use of subant which will cause the resolution of all dependencies
of that target and so on. In other words, it'd be ugly. Although, the code duplication is
an awful thing it seems to be a good enough solution in this case. 
Besides, it isn't a duplication of the code: this is merely a duplication of macro call.

> Add new unit tests to the 10-mins 'run-commit-test' target
> ----------------------------------------------------------
>
>                 Key: HDFS-806
>                 URL: https://issues.apache.org/jira/browse/HDFS-806
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-806.patch, HDFS-806.patch, HDFS-806.patch, HDFS-806.patch
>
>
> The reason to add these test is that they are true unit tests thus running very fast
while testing pretty significant parts of the HDFS code base. Additional time is very short
(<3 secs) and won't affect 10 mins commit testing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message