Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Message-ID: <17136367.165761275593096597.JavaMail.jira@thor>
Date: Thu, 3 Jun 2010 15:24:56 -0400 (EDT)
From: "Konstantin Shvachko (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Subject: [jira] Commented: (HDFS-1185) Remove duplicate now() functions in
 DataNode, FSNamesystem
In-Reply-To: <19093648.153541275548578894.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875259#action_12875259 ] 

Konstantin Shvachko commented on HDFS-1185:
-------------------------------------------

Sounds like a good idea. One nit. It would be nice to use import static, like this
{code}
import static org.apache.hadoop.hdfs.server.common.Util.now;
{code}
Then direct calls to {{now()}} in FDNamesystem and DataNode will remain unchanged. In other places it will just say {{now}}.

> Remove duplicate now() functions in DataNode, FSNamesystem
> ----------------------------------------------------------
>
>                 Key: HDFS-1185
>                 URL: https://issues.apache.org/jira/browse/HDFS-1185
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node, name-node
>            Reporter: Jeff
>            Priority: Minor
>         Attachments: HDFS-1185.patch
>
>
> An identical now() function is defined in Util, DataNode, and FSNamesystem.  This patch removes the latter two and converts all calls to use the Util.now function.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.