hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1197) 0.20: TestFileAppend3.testTC2 failure
Date Mon, 14 Jun 2010 04:28:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878468#action_12878468
] 

Todd Lipcon commented on HDFS-1197:
-----------------------------------

I think this was introduced by the following part of the HDFS-200 patch:
{code}
-        }
-      }
-      if (closeFile) {
-        // the file is getting closed. Insert block locations into blocksMap.
-        // Otherwise fsck will report these blocks as MISSING, especially if the
-        // blocksReceived from Datanodes take a long time to arrive.
-        for (int i = 0; i < descriptors.length; i++) {
           descriptors[i].addBlock(newblockinfo);
         }
-        pendingFile.setLastBlock(newblockinfo, null);
-      } else {
-        // add locations into the INodeUnderConstruction
-        pendingFile.setLastBlock(newblockinfo, descriptors);
       }
+      // add locations into the INodeUnderConstruction
+      pendingFile.setLastBlock(newblockinfo, descriptors);
     }
{code}

I have some unit tests to show the issue, and working on a fix. I think this should be considered
a blocker for 0.20-append

> 0.20: TestFileAppend3.testTC2 failure
> -------------------------------------
>
>                 Key: HDFS-1197
>                 URL: https://issues.apache.org/jira/browse/HDFS-1197
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node, hdfs client, name-node
>    Affects Versions: 0.20-append
>            Reporter: Todd Lipcon
>         Attachments: testTC2-failure.txt
>
>
> I saw this failure once on my internal Hudson job that runs the append tests 48 times
a day:
> junit.framework.AssertionFailedError: expected:<114688> but was:<98304>
> 	at org.apache.hadoop.hdfs.AppendTestUtil.check(AppendTestUtil.java:112)
> 	at org.apache.hadoop.hdfs.TestFileAppend3.testTC2(TestFileAppend3.java:116)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message