Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 85566 invoked from network); 22 May 2010 00:52:38 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 22 May 2010 00:52:38 -0000 Received: (qmail 61807 invoked by uid 500); 22 May 2010 00:52:38 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 61722 invoked by uid 500); 22 May 2010 00:52:38 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 61714 invoked by uid 99); 22 May 2010 00:52:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 May 2010 00:52:38 +0000 X-ASF-Spam-Status: No, hits=-1454.2 required=10.0 tests=ALL_TRUSTED,AWL,FS_WILL_HELP X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 May 2010 00:52:37 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o4M0qH0H020688 for ; Sat, 22 May 2010 00:52:17 GMT Message-ID: <8775636.32641274489537602.JavaMail.jira@thor> Date: Fri, 21 May 2010 20:52:17 -0400 (EDT) From: "Konstantin Boudnik (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Resolved: (HDFS-608) BlockReceiver:receivePacket(): packet's header parsing logic is complicated. Refactoring will help w/ testing efforts In-Reply-To: <368200382.1252535037673.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Boudnik resolved HDFS-608. ------------------------------------- Resolution: Duplicate This is DUP of HDFS-881 > BlockReceiver:receivePacket(): packet's header parsing logic is complicated. Refactoring will help w/ testing efforts > --------------------------------------------------------------------------------------------------------------------- > > Key: HDFS-608 > URL: https://issues.apache.org/jira/browse/HDFS-608 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Konstantin Boudnik > Assignee: Konstantin Boudnik > Attachments: HDFS-608.patch > > > Current logic of getting an information from a packet header is kinda complicated with all shifting along the internal data buffer back and forth. > Besides, an absence of clear API to access a packet header's information makes pipeline testing effort (even with aspects' application) to be a very complicated or even impossible. > It'd be very nice to have a separate data container which will keep all the information about a packet header within and will initialized once when a new packet is acquired. > In order to speed-up pipeline testing needed for append (HDFS-265) this modification might implemented in three different states: > - introduce new header structure and refactor receivePacket() > - refactor readNextPacket so it it will acquire next packet in initialize its header > - refactor the sender side to use the packet's header structure as the receiver does. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.