Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 31902 invoked from network); 18 May 2010 05:47:20 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 18 May 2010 05:47:20 -0000 Received: (qmail 28582 invoked by uid 500); 18 May 2010 05:47:20 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 28553 invoked by uid 500); 18 May 2010 05:47:20 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 28417 invoked by uid 99); 18 May 2010 05:47:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 May 2010 05:47:19 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 May 2010 05:47:17 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o4I5kunJ014191 for ; Tue, 18 May 2010 05:46:56 GMT Message-ID: <4373073.99531274161616002.JavaMail.jira@thor> Date: Tue, 18 May 2010 01:46:56 -0400 (EDT) From: "Todd Lipcon (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-1142) Lease recovery doesn't reassign lease when triggered by append() In-Reply-To: <3644025.7991273533151827.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868541#action_12868541 ] Todd Lipcon commented on HDFS-1142: ----------------------------------- bq. The test assumes that hflush() should not succeed after the recovery started, but this assumption is incorrect. HBase is using contracts like this to do IO fencing during regionserver recovery operations (eg see discussion on HBASE-2231 and HBASE-2238). The ability to use lease recovery to lock out a writer whose soft lease has expired provides lock-like functionality tied to the storage. Without HDFS itself providing a file locking primitive, it becomes essentially impossible to do correct recovery in systems like HBase where an old writer needs to be forcibly disallowed from continued progress. Using an external system like ZK since it is asynchronous in nature. Let me think if we have an alternate route to the same kind of behavior using the semantics you're describing. > Lease recovery doesn't reassign lease when triggered by append() > ---------------------------------------------------------------- > > Key: HDFS-1142 > URL: https://issues.apache.org/jira/browse/HDFS-1142 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 0.21.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Blocker > Attachments: hdfs-1142.txt, hdfs-1142.txt > > > If a soft lease has expired and another writer calls append(), it triggers lease recovery but doesn't reassign the lease to a new owner. Therefore, the old writer can continue to allocate new blocks, try to steal back the lease, etc. This is for the testRecoveryOnBlockBoundary case of HDFS-1139 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.