Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 84288 invoked from network); 11 May 2010 02:19:54 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 11 May 2010 02:19:54 -0000 Received: (qmail 17223 invoked by uid 500); 11 May 2010 02:19:54 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 17142 invoked by uid 500); 11 May 2010 02:19:54 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 17134 invoked by uid 99); 11 May 2010 02:19:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 May 2010 02:19:54 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 May 2010 02:19:52 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o4B2JUGt000501 for ; Tue, 11 May 2010 02:19:30 GMT Message-ID: <31624198.11881273544370600.JavaMail.jira@thor> Date: Mon, 10 May 2010 22:19:30 -0400 (EDT) From: "dhruba borthakur (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-1138) Modification times are being overwritten when FSImage loads In-Reply-To: <4722154.1651273519351175.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866022#action_12866022 ] dhruba borthakur commented on HDFS-1138: ---------------------------------------- The behaviour you describe is clearly a bug. can somebody please review this one? > Modification times are being overwritten when FSImage loads > ----------------------------------------------------------- > > Key: HDFS-1138 > URL: https://issues.apache.org/jira/browse/HDFS-1138 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Dmytro Molkov > Assignee: Dmytro Molkov > Attachments: HDFS-1138 > > > A very easy way to spot the bug is to do a second restart in TestRestartDFS and check that the modification time on root is the same as it was before the second restart. > The problem is modifying time of the parent if the modification time of the child is greater than parent's in addToParent. > So if you have /DIR/File then on creation of a file modification time of the DIR will be set, but on cluster restart, or when secondary is checkpointing and reading the image it will add DIR to "/" and write the new modification time for "/" which is the modification time of DIR. > This is clearly a bug. I will attach a patch with one more parameter being passed from the loadFSImage that says to not propagate the time. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.