Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Message-ID: <29082484.46131274828616445.JavaMail.jira@thor>
Date: Tue, 25 May 2010 19:03:36 -0400 (EDT)
From: "Konstantin Shvachko (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Subject: [jira] Commented: (HDFS-1142) Lease recovery doesn't reassign lease
 when triggered by append()
In-Reply-To: <3644025.7991273533151827.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871407#action_12871407 ] 

Konstantin Shvachko commented on HDFS-1142:
-------------------------------------------

Sam. Sounds like you are looking at 0.20 version, because in 0.22 sync has been replaced with hflush(). Please clarify.
Could you also please indicate whether you can actually reproduce it or have a test case. If you do please open a new jira.
Looking at the code (0.22) I think there might be a problem there. 
In getAdditionalBlock() we do not reset recoveryId of the last block before allocating a new one.
The reset should be done in {{BlockInfoUnderConstruction.commitBlock()}}.

> Lease recovery doesn't reassign lease when triggered by append()
> ----------------------------------------------------------------
>
>                 Key: HDFS-1142
>                 URL: https://issues.apache.org/jira/browse/HDFS-1142
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-1142.txt, hdfs-1142.txt
>
>
> If a soft lease has expired and another writer calls append(), it triggers lease recovery but doesn't reassign the lease to a new owner. Therefore, the old writer can continue to allocate new blocks, try to steal back the lease, etc. This is for the testRecoveryOnBlockBoundary case of HDFS-1139

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.