Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 8702 invoked from network); 8 May 2010 02:23:13 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 8 May 2010 02:23:13 -0000 Received: (qmail 2996 invoked by uid 500); 8 May 2010 02:23:13 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 2951 invoked by uid 500); 8 May 2010 02:23:13 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 2943 invoked by uid 99); 8 May 2010 02:23:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 May 2010 02:23:13 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 May 2010 02:23:11 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o482MnoF003753 for ; Sat, 8 May 2010 02:22:49 GMT Message-ID: <16915358.45671273285369220.JavaMail.jira@thor> Date: Fri, 7 May 2010 22:22:49 -0400 (EDT) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-1132) Refactor TestFileStatus In-Reply-To: <30767035.29361273090382561.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865385#action_12865385 ] Hadoop QA commented on HDFS-1132: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443813/hdfs-1132-3.patch against trunk revision 942003. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/347/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/347/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/347/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/347/console This message is automatically generated. > Refactor TestFileStatus > ----------------------- > > Key: HDFS-1132 > URL: https://issues.apache.org/jira/browse/HDFS-1132 > Project: Hadoop HDFS > Issue Type: Test > Components: test > Affects Versions: 0.22.0 > Reporter: Eli Collins > Assignee: Eli Collins > Priority: Minor > Fix For: 0.22.0 > > Attachments: hdfs-1132-1.patch, hdfs-1132-2.patch, hdfs-1132-3.patch > > > When writing HADOOP-6585 I noticed TestFileStatus is an old test with just one monolithic test function. We should rewrite it as a junit4 style test and break up the functions into setup, teardown, and five individual test cases. Same tests being run, just easier to follow, modify and add news tests. Patch coming. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.