hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1141) completeFile does not check lease ownership
Date Tue, 11 May 2010 15:56:45 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866187#action_12866187

Todd Lipcon commented on HDFS-1141:

Thanks for taking a look, Nicolas.

bq. Minor: Look like that pendingFile won't be null since the checkLease(..) method below
will throw a LeaseExpiredException when file == null.

Not sure what you're referring to - the patch removes the checks against pendingFile == null.
We now check only for fileBlocks == null. Are you suggesting I remove fileBlocks and the associated
null check? That seems reasonable, since fileBlocks itself isn't used outside the null check.

> completeFile does not check lease ownership
> -------------------------------------------
>                 Key: HDFS-1141
>                 URL: https://issues.apache.org/jira/browse/HDFS-1141
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>         Attachments: hdfs-1141-branch20.txt, hdfs-1141.txt
> completeFile should check that the caller still owns the lease of the file that it's
completing. This is for the 'testCompleteOtherLeaseHoldersFile' case in HDFS-1139.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message