hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1141) completeFile does not check lease ownership
Date Tue, 11 May 2010 15:17:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866176#action_12866176
] 

Tsz Wo (Nicholas), SZE commented on HDFS-1141:
----------------------------------------------

+1 thanks for working on it, Todd.

Minor: Look like that pendingFile won't be null since the checkLease(..) method below will
throw a LeaseExpiredException when file == null.
{code}
//FSNamesystem
  private void checkLease(String src, String holder, INode file) 
                                                     throws IOException {

    if (file == null || file.isDirectory()) {
      Lease lease = leaseManager.getLease(holder);
      throw new LeaseExpiredException("No lease on " + src +
      ...
{code}

> completeFile does not check lease ownership
> -------------------------------------------
>
>                 Key: HDFS-1141
>                 URL: https://issues.apache.org/jira/browse/HDFS-1141
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>         Attachments: hdfs-1141-branch20.txt, hdfs-1141.txt
>
>
> completeFile should check that the caller still owns the lease of the file that it's
completing. This is for the 'testCompleteOtherLeaseHoldersFile' case in HDFS-1139.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message