hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1119) Refactor BlocksMap with GettableSet
Date Tue, 25 May 2010 01:26:24 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870939#action_12870939
] 

Konstantin Shvachko commented on HDFS-1119:
-------------------------------------------

I see that the get method in the new {{GettableSet}} interface is similar to
{code}
V get(Object key)
{code}
So I'd propose 
# to call the parameter {{key}} instead of {{element}}
# to call the interface {{KeySet}}
# then the HashMap based implementation can be called {{HashKeySet}}

On the patch itself, it would be good to put a comment after @Override indicating which class
it actually overrides. Simplifies life.
{code}
@Override // GettableSet
public int size() {
...
{code}


> Refactor BlocksMap with GettableSet
> -----------------------------------
>
>                 Key: HDFS-1119
>                 URL: https://issues.apache.org/jira/browse/HDFS-1119
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>         Attachments: h1119_20100429.patch, h1119_20100506.patch, h1119_20100521.patch
>
>
> The data structure required in BlocksMap is a GettableSet.  See also [this comment|https://issues.apache.org/jira/browse/HDFS-1114?focusedCommentId=12862118&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12862118].

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message