hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1138) Modification times are being overwritten when FSImage loads
Date Tue, 11 May 2010 22:43:42 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866375#action_12866375
] 

Hadoop QA commented on HDFS-1138:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12444237/HDFS-1138.2.patch
  against trunk revision 943214.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/176/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/176/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/176/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/176/console

This message is automatically generated.

> Modification times are being overwritten when FSImage loads
> -----------------------------------------------------------
>
>                 Key: HDFS-1138
>                 URL: https://issues.apache.org/jira/browse/HDFS-1138
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Dmytro Molkov
>            Assignee: Dmytro Molkov
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1138, HDFS-1138.2.patch
>
>
> A very easy way to spot the bug is to do a second restart in TestRestartDFS and check
that the modification time on root is the same as it was before the second restart.
> The problem is modifying time of the parent if the modification time of the child is
greater than parent's in addToParent.
> So if you have /DIR/File then on creation of a file modification time of the DIR will
be set, but on cluster restart, or when secondary is checkpointing and reading the image it
will add DIR to "/" and write the new modification time for "/" which is the modification
time of DIR.
> This is clearly a bug. I will attach a patch with one more parameter being passed from
the loadFSImage that says to not propagate the time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message