hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Molkov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1028) INode.getPathNames could split more efficiently
Date Wed, 05 May 2010 22:52:06 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864570#action_12864570
] 

Dmytro Molkov commented on HDFS-1028:
-------------------------------------

Good point, I will remove the changes from the UnitTest. One image I tested it on with 3.5
million files got a speedup of ~18% 36 second vs 30 seconds. We were not testing the change
on bigger images yet.

> INode.getPathNames could split more efficiently
> -----------------------------------------------
>
>                 Key: HDFS-1028
>                 URL: https://issues.apache.org/jira/browse/HDFS-1028
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Todd Lipcon
>            Assignee: Dmytro Molkov
>            Priority: Minor
>         Attachments: HDFS-split.2.patch, HDFS-split.patch
>
>
> INode.getPathnames uses String.split(String) which actually uses the full Java regex
implementation. Since we're always splitting on a single char, we could implement a faster
one like StringUtils.split() (except without the escape character). This takes a significant
amount of CPU during FSImage loading so should be a worthwhile speedup.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message