hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-921) Convert TestDFSClientRetries::testNotYetReplicatedErrors to Mockito
Date Mon, 26 Apr 2010 19:30:36 GMT

    [ https://issues.apache.org/jira/browse/HDFS-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861061#action_12861061
] 

Konstantin Boudnik commented on HDFS-921:
-----------------------------------------

bq. If we did, TestDFSClientRetries actually probably wouldn't qualify because a new test
that got added recently uses MiniDFSCluster and takes more than a minute to run.

Yeah, you are right - I have revisited the patch and I can see it now. As for the 'loneliness':
there are two more unit tests already :)

> Convert TestDFSClientRetries::testNotYetReplicatedErrors to Mockito
> -------------------------------------------------------------------
>
>                 Key: HDFS-921
>                 URL: https://issues.apache.org/jira/browse/HDFS-921
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.22.0
>
>         Attachments: HDFS-921-2.patch, HDFS-921.patch
>
>
> When TestDFSClientRetries::testNotYetReplicatedErrors was written, Mockito was not available
and the NameNode was mocked by manually extending ClientProtocol and implementing all the
methods, most with empty bodies.  Now that we have Mockito, this code can be removed and replaced
with an actual mock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message