hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-921) Convert TestDFSClientRetries::testNotYetReplicatedErrors to Mockito
Date Mon, 26 Apr 2010 18:56:32 GMT

    [ https://issues.apache.org/jira/browse/HDFS-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861050#action_12861050
] 

Jakob Homan commented on HDFS-921:
----------------------------------

bq. Actually, I was about to suggest to move this test into src/test/unit because now it looks
like a real unit test. Shall I open a separate JIRA for that? What do you think?
The src/test/unit directory is vexing. We should definitely have a JIRA for moving those tests
that can be truly called unit tests to it; I'm just afraid it'll be a lonely little directory
tree at the moment.  If we did, TestDFSClientRetries actually probably wouldn't qualify because
a new test that got added recently uses MiniDFSCluster and takes more than a minute to run...
 It's worth a JIRA though.

> Convert TestDFSClientRetries::testNotYetReplicatedErrors to Mockito
> -------------------------------------------------------------------
>
>                 Key: HDFS-921
>                 URL: https://issues.apache.org/jira/browse/HDFS-921
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>            Reporter: Jakob Homan
>            Assignee: Jakob Homan
>             Fix For: 0.22.0
>
>         Attachments: HDFS-921-2.patch, HDFS-921.patch
>
>
> When TestDFSClientRetries::testNotYetReplicatedErrors was written, Mockito was not available
and the NameNode was mocked by manually extending ClientProtocol and implementing all the
methods, most with empty bodies.  Now that we have Mockito, this code can be removed and replaced
with an actual mock.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message